Open Courey opened 1 month ago
When you delete synonyms, does it double check you meant to delete them? If not, it would be good to do so.
When you delete synonyms, does it double check you meant to delete them? If not, it would be good to do so.
It does not currently, but that is definitely something I can add in!
Here are updated images to show the additional request for a modal making sure you want to delete a synonym group. I also updated the trashcan icon next to each eventId so that it says remove instead of just uses an icon.
Attention: Patch coverage is 11.93182%
with 155 lines
in your changes missing coverage. Please review.
Project coverage is 6.23%. Comparing base (
54ea8ce
) to head (8a67744
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
With nothing on the page yet
when you type 3 or more characters
When you hover over one of the options
Description
This is the front end for the moderation portion of synonyms (not the circular index grouped by synonyms, but the ability to create, put, delete the synonyms themselves). It is behind both a feature flag and a moderator check. The majority of the code is behind a feature flag and moderation gate, but I did create a component for pagination to reduce redundancy so I could reuse it for this work. In order to do that I had to update the circulars index page as well. That portion is NOT behind a feature flag.
Related Issue(s)
Resolves #2116
Testing
This is the moderation index with pagination. Links for each group are to the detail page
This is the detail page for a synonym group. The button to save is disabled because no additional eventIds have been added. It is enabled when a new eventId is added.
This is the error shown if you enter an eventId that doesn't exist.
This is the create view with no eventIds added.
This is the same view with eventIds added.
This is the error shown when you try to create a synonym group with an invalid eventId