Closed jracusin closed 2 months ago
The Kafka part of this is dead simple: I think that we should always send revised Circulars over Kafka. https://github.com/nasa-gcn/gcn.nasa.gov/pull/2568
@lpsinger and @jracusin can you revise the acceptance criteria for this ticket? If we are going to always send the revised circular, what changes are left to make?
Are we? I think it is clear that we should always send the Kafka record. I am less sure if we always want to send the email.
Ah I see, I thought by your update we were just going to always send the messages either way. All good then
@jracusin @lpsinger for the reminder to the mods, is something like this what y'all have in mind?
Also can you give me a list of what these changes are?
@jracusin @lpsinger for the reminder to the mods, is something like this what y'all have in mind?
No. If there is a checkbox, then the documentation about it should be in the label for the checkbox, not at the top of the page.
Gotcha, as for the changes themselves, what are they?
None as far as I can tell. Just that detailed instructions related to a field in a form should usually go in or near the label for the control itself. Here's an example:
Description
When authors request a major change to a Circular (e.g. trigger time or magnitudes/flux change), give moderator option to distribute new version via email/Kafka.
Acceptance criteria