search

nasa-gcn / gcn.nasa.gov

General Coordinates Network (GCN) web site
https://gcn.nasa.gov
Other
182 stars 43 forks source link

Updating to remix > 2.10.3 breaks hyperlinks for Circulars cross-references #2564

Open lpsinger opened 2 months ago

lpsinger commented 2 months ago

Follow-up of #2563.

Current behavior

If we update all of the @remix-run/* packages to versions newer than (but not including) 2.10.3, then on pages for Circulars that contain many cross-references, we find that some of the hyperlinks to other Circulars don't work. Clicking the Circulars hyperlink causes the URL to update in the address bar, but the page itself does not update.

Expected behavior

The page should update.

Steps to reproduce

  1. Update all Remix packages to versions newer than (but not including) 2.10.3.
  2. Run npm run dev.
  3. Navigate to http://localhost:3333/circulars/34576.
  4. Try to follow any of the Circulars cross-reference hyperlinks

Environment

Any browser, desktop or mobile.

Notes

I used git bisect on the remix project and came up with a list of candidate commits that might have introduced this buggy behavior. I ruled out a few of the matching commits because they only updated package metadata or non-functional files like TypeScript .d.ts files. Here are the candidates: