search

nasa-gcn / gcn.nasa.gov

General Coordinates Network (GCN) web site
https://gcn.nasa.gov
Other
182 stars 43 forks source link

Address issue raised on gcn-schema #189 #2584

Closed jessiethw closed 1 month ago

jessiethw commented 1 month ago

Clarify the case for when the "most_probable_direction" key is included in the lvk_nu_track_search follow up GCN, raised in nasa-gcn/gcn-schema#189

The most probable direction is included when the p-value for the generic transient search is <10%. This PR updates the IceCube docs to reflect this case.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 6.10%. Comparing base (ce005eb) to head (e558b26). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2584 +/- ## ===================================== Coverage 6.10% 6.10% ===================================== Files 164 164 Lines 4065 4065 Branches 444 444 ===================================== Hits 248 248 Misses 3815 3815 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jessiethw commented 1 month ago

@jessiethw, this looks good to me. Can you recommend someone as a reviewer? Would @blaufuss be a good choice?

thanks, and yes that would be great!