search

nasa-gcn / gcn.nasa.gov

General Coordinates Network (GCN) web site
https://gcn.nasa.gov
Other
179 stars 43 forks source link

Moves the definition of the send function to resolve issues with kafka related imports in the remix build #2590

Open dakota002 opened 6 hours ago

dakota002 commented 6 hours ago

Resolves #2588

Still in testing

It looks like the issue started with this commit

This PR moves the definition of the send function so it can still be reusable

codecov[bot] commented 6 hours ago

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 6.08%. Comparing base (54ea8ce) to head (a1c703a).

Files with missing lines Patch % Lines
app/lib/email.server.ts 0.00% 31 Missing :warning:
app/routes/circulars/circulars.server.ts 0.00% 1 Missing :warning:
app/table-streams/circulars/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2590 +/- ## ===================================== Coverage 6.08% 6.08% ===================================== Files 164 164 Lines 4077 4074 -3 Branches 450 450 ===================================== Hits 248 248 + Misses 3827 3824 -3 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lpsinger commented 6 hours ago

This won't fix the issue. The problem is that the zstd shared library is not getting bundled.

dakota002 commented 5 hours ago

This won't fix the issue. The problem is that the zstd shared library is not getting bundled.

I'm investigating this as an option for the first possible solution you mentioned. "Ensure that it is always the table stream Lambda that is sending Kafka records"

The table-stream lambda already is the only thing sending Kafka records. But, since it was exporting a function that gets used in the remix lambda, I'm trying to determine whether or not that meant that its dependencies are getting tangled up in an unintended way.

The main issue that I am seeing though is that this may be suggesting the problem is also going to be present in https://github.com/nasa-gcn/gcn.nasa.gov/pull/2301

Still investigating though, I think the better solution will be to figure out the inclusion of the lib, but in the meantime this may be a good option to unblock the broken deployments

lpsinger commented 22 minutes ago

I'm investigating this as an option for the first possible solution you mentioned.

I understand now. Go for it!