Tours are not zooming to the correct location

nasa-gibs / worldview

Interactive interface for browsing global, full-resolution satellite imagery

https://worldview.earthdata.nasa.gov/

Other

707 stars 187 forks source link

Tours are not zooming to the correct location #2929

Closed minniewong closed 4 years ago

minniewong commented 4 years ago

Describe the bug On SIT, when starting a tour e.g. Australia fires, the first step should zoom to Australia, but the map is not zooming to the location.

To Reproduce Steps to reproduce the behavior:

Go to SIT
Click on Australia fires tour
See that map does not zoom to Australia
same issue with other tours

Expected behavior The map should zoom to the correct location

Screenshots

Desktop (please complete the following information):

OS: OSX
Browser: Chrome, firefox

edplato commented 4 years ago

Started debugging this. The issue appears to arise at https://github.com/nasa-gibs/worldview/commit/f84c1a203917632af0741d9b14c80fcc9abf05c1

If I replace the package-lock.json with the previous commit's package-lock.json and run npm install && npm run build, it seems to work normal. I'm not sure if this commit is the cause or just a catalyst of the real issue. This led me to removing the package-lock.json from develop and running npm install && npm run build, which fixes the bug. I tested npm run build:prod and that seems to be fixed as well. I'm not sure if this a valid direction for a fix or not since we lose the package-lock.json.

Any thoughts?

Benjaki2 commented 4 years ago

I don't see a problem with reverting to an older package-lock since it seems like a dependency update made this happen.

jasontk19 commented 4 years ago

I guess my only concern with that approach to fix this is... what happens when that dependency eventually does get updated in the future? I guess we could kick this can down the road by reverting the package-lock but maybe still need to leave the issue open?