search

nasa-gibs / worldview

Interactive interface for browsing global, full-resolution satellite imagery
https://worldview.earthdata.nasa.gov/
Other
702 stars 187 forks source link

Error thrown on changing date on tour step #3392

Closed edplato closed 3 years ago

edplato commented 3 years ago

Describe the bug Error thrown on changing date on tour step. The error appears to happen in web\js\map\ui.js updateDate().

To Reproduce Steps to reproduce the behavior:

  1. Go to ?l=VIIRS_SNPP_Thermal_Anomalies_375m_Day(hidden),VIIRS_SNPP_Thermal_Anomalies_375m_Night(hidden),Reference_Labels(hidden),Reference_Features(hidden),Coastlines,VIIRS_SNPP_CorrectedReflectance_TrueColor,MODIS_Aqua_CorrectedReflectance_TrueColor(hidden),MODIS_Terra_CorrectedReflectance_TrueColor(hidden)&lg=false&tr=australia_fires_2019_2020&t=2019-09-07-T15%3A25%3A24Z
  2. Click through tour step till STEP 5
  3. Click left arrow to change date
  4. See error Uncaught TypeError: Cannot read property 'forEach' of undefined

Also seeing same error if change date is done after STEP 7 - it should be noted for debug that both steps before STEP 5 and STEP 7 had animations.

Desktop (please complete the following information):

minniewong commented 3 years ago

Also, the map is not zooming to the correct locations for steps 5 and 7

jasontk19 commented 3 years ago

Hmmm, I am getting a different error: 

Uncaught TypeError: Cannot read property 'ol_uid' of undefined
    at getUid (util.js:28)
edplato commented 3 years ago

I'm seeing that one as well. It looks like the Uncaught TypeError: Cannot read property 'forEach' of undefined error requires a second date change to throw.

jasontk19 commented 3 years ago

Ah yeah, I see both now. Guessing the first one is the primary issue. I also see the zoom issue @minniewong but my first guess would be that this is a separate bug. @edplato would you mind digging into that one while I look at the date change issue?