nasa-gibs / worldview

Interactive interface for browsing global, full-resolution satellite imagery
https://worldview.earthdata.nasa.gov/
Other
693 stars 183 forks source link

WV-3237 Alert users if snapshot exceeds GRANULE_LIMIT #5394

Closed PatchesMaps closed 1 month ago

PatchesMaps commented 1 month ago

Description

Alert users if snapshot exceeds GRANULE_LIMIT

How To Test

  1. git checkout WV-3237-exceed-snapshot
  2. npm run watch
  3. Open this link.
  4. Open the snapshot modal.
  5. Verify that the warning appears in the modal.

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

Tomcariello commented 1 month ago

I don't think this is related to your work, but I keep getting "Invalid value for GRANULE_DATES" for a bunch of WVS requests.

Tomcariello commented 1 month ago

Do we want to this to calculate once at the time of the snapshot start? Or should it be calculated as the snapshot selection window is adjusted? I may have lots of granules on screen but if I only have a couple granules in my snapshot selection the warning doesn't apply.

PatchesMaps commented 1 month ago

Do we want to this to calculate once at the time of the snapshot start? Or should it be calculated as the snapshot selection window is adjusted? I may have lots of granules on screen but if I only have a couple granules in my snapshot selection the warning doesn't apply.

@Tomcariello We currently don't have the ability to send only the granules intersecting the snapshot selection. All of the granules loaded get sent to the server regardless of what the snapshot extent is focused on. So with the current functionality it makes the most sense to calculate this at the time of the snapshot start since the layers can't be modified once the snapshot workflow begins. If we want to add/change the functionality to only send the granules intersecting the snapshot bounding box then it would make the most sense to calculate this whenever the bounding box changes. I think that would be a story separate from this one though.

PatchesMaps commented 1 month ago

I don't think this is related to your work, but I keep getting "Invalid value for GRANULE_DATES" for a bunch of WVS requests.

@Tomcariello Can you create a new story/ticket to address the error you're seeing?

Tomcariello commented 1 month ago

If we want to add/change the functionality to only send the granules intersecting the snapshot bounding box then it would make the most sense to calculate this whenever the bounding box changes. I think that would be a story separate from this one though.

Understood. We should definitely create a ticket to see if we can only send granules that are included in the snapshot selection area.