search

nasa-jpl-memex / GeoParser

Extract and Visualize location from any file
Apache License 2.0
52 stars 23 forks source link

Added Search Code #62

Closed antrromet closed 8 years ago

antrromet commented 8 years ago

@smadha @chrismattmann @MBoustani Guys, I've added the basic search code. Its fully functional and can be rolled out. A couple of things to note though.

  1. As of now, I'm displaying only the title and dc-title keys in the search results. We will have to change this. Again some kind of option I guess as to what results to be seen in the search results. Maybe a popup or a config file, similar to the discussion happening here.
  2. Also, we need some paging kind of mechanism where the user can see further search results. As of now we are fetching just the first 10 (by default 10 rows are fetched in solr). We need to decide about the design of the search results. Lemme know what you guys think.
chrismattmann commented 8 years ago

LOVE this @antrromet

antrromet commented 8 years ago

Adding a screenshot for reference.

screen shot 2016-04-02 at 11 42 21 am
smadha commented 8 years ago

@antrromet I see some code which I have already merged in PR #61 I just created a new branch search from master. Can we work on this branch please?

Maybe you can close this PR and raise it again on new branch.

Thanks

chrismattmann commented 8 years ago

@smadha can you just merge this PR into the branch just gir pull right

chrismattmann commented 8 years ago

*git

antrromet commented 8 years ago

@smadha Lemme know if you are unable to do so. I will make another PR if needed.

smadha commented 8 years ago

@chrismattmann @antrromet I can try doing that. But as I said there is some code which I have already merged in PR #61. That's why I asked for new one to make it cleaner

But let me try merge this PR into the branch and I will update here

smadha commented 8 years ago

Merged via #64 in GeoParser/tree/search

MBoustani commented 8 years ago

@antrromet looks great.