search

nasa-jpl-memex / image_space

Interactive Image similarity and Visual Search and Retrieval application
Apache License 2.0
93 stars 46 forks source link

Upper Casing FileNames in Search Results #156

Closed harsham05 closed 8 years ago

harsham05 commented 8 years ago

@danlamanna May I please know why we are upper casing search results, which affects the HTTP file mount resulting in broken image links?

https://github.com/memex-explorer/image_space/blob/master/imagespace/server/imagesearch_rest.py#L128

I am guessing this is specific to weapons. This affects deployment to other domains.

FYI, I am using parser-indexer Pipeline for Solr ingestion.

Thank you!

danlamanna commented 8 years ago

Yup, this is specific to weapons - only recently has ImageSpace started separating this sort of logic out into a weapons-specific plugin.

I'll separate this out in a PR later today, it should be trivial to do. There are certainly other areas that are weapons specific in the codebase that need to be decoupled; we are mostly dealing with these as they arise, so feel free to put in issues if/when you encounter other instances.

harsham05 commented 8 years ago

Thanks @danlamanna !

danlamanna commented 8 years ago

Closed via #157