search

nasa-jpl-memex / weapons

MEMEX Weapons Pilot for the illegal weapons domain.
http://memex.jpl.nasa.gov
Apache License 2.0
14 stars 14 forks source link

fix facetview browser nav & share link generation #6

Closed msarahan closed 8 years ago

msarahan commented 8 years ago

Back and forward buttons now work properly. Fix share link button to create useful link. Insert space after set of all images for ads view.

chrismattmann commented 8 years ago

hey @msarahan I think this PR needs to be updated to master and then can be merged.

msarahan commented 8 years ago

@chrismattmann merged - thanks.

chrismattmann commented 8 years ago

thanks @msarahan if you haven't deployed this yet I'll take a crack this weekend.

msarahan commented 8 years ago

@chrismattmann this is deployed. I had to clear my browser cache to make the browser back/forward buttons work, though - just be aware of that limitation. Presumably some old javascript file is getting cached and needs to be cleared to allow the new one to be used.

On Sun, Jan 17, 2016 at 12:41 AM Chris Mattmann notifications@github.com wrote:

thanks @msarahan https://github.com/msarahan if you haven't deployed this yet I'll take a crack this weekend.

— Reply to this email directly or view it on GitHub https://github.com/memex-explorer/weapons/pull/6#issuecomment-172295966.