include <numpy/arrayobject.h> not needed

nasa-jpl / autoRIFT

A Python module of a fast and intelligent algorithm for finding the pixel displacement between two images

Apache License 2.0

218 stars 53 forks source link

include <numpy/arrayobject.h> not needed #10

Closed piyushrpt closed 4 years ago

piyushrpt commented 4 years ago

I don't think this header file is needed for autorift. It is included but never used. Will keep the compile line shorter and easier to integrate with other tools.

piyushrpt commented 4 years ago

@rtburns-jpl - FYI

leiyangleon commented 4 years ago

I don't think this header file is needed for autorift. It is included but never used. Will keep the compile line shorter and easier to integrate with other tools.

I remember it was used; otherwise, compiling would fail, which is why I added it. I just checked the code, see the declaration of PyArrayObject in sub-function arPixDisp_u. There are another three similar uses in the c++ binding file autoriftcoremodule.cpp .

piyushrpt commented 4 years ago

Got it. My bad. Yep - it is needed.