nasa-jpl / autoRIFT

A Python module of a fast and intelligent algorithm for finding the pixel displacement between two images
Apache License 2.0
218 stars 53 forks source link

Allow usage of GDAL's virtual file systems #16

Closed jhkennedy closed 3 years ago

jhkennedy commented 3 years ago

Instead of modifying http://... paths with /vsicurl/, this instead:

Also moves main driver inside a main() function, and does:

if __name__ == '__main__':
   main()

So that the test scripts can turned into entrypoints if vendored downstream (ideally, geo_autoRIFT would just provides these inside the package and add entrypoints for script access when the package is installed, but that can be tackled in a subsequent PR).

jhkennedy commented 3 years ago

Currently marked as draft to get other eyes on it while I'm testing -- will mark as ready for review when I've used this to run S1, S2, and L8 jobs.

jhkennedy commented 3 years ago

Marking this as ready for review because it will build fine in both the autoRIFT and ISCE2 conda-forge feedstocks.

Still have not utilized this end-to-end for S1, S2, or L8; working on that now.

leiyangleon commented 3 years ago

Just read through the changes, which looks great. Well done, @jhkennedy ! Happy to merge it.