nasa-jpl / autoRIFT

A Python module of a fast and intelligent algorithm for finding the pixel displacement between two images
Apache License 2.0
212 stars 52 forks source link

Correct computation of v_error #68

Closed mliukis closed 1 year ago

mliukis commented 1 year ago

As @alex-s-gardner pointed out, the paper and production code need to be corrected in computations of v_error:

https://github.com/nasa-jpl/autoRIFT/blob/e683e485b0e194a0b63def90ccbdee11ad56fb2a/netcdf_output.py#L697

It should be changed to: v_err = (vx_err.*abs(vx) + vy_err.*abs(vy))./v

alex-s-gardner commented 1 year ago

I discussed this with Yang and the error formulation in the paper is correct. We may need to update our Mosaic code

jhkennedy commented 1 year ago

@alex-s-gardner so, the netcdf_ouput.py doesn't need to be updated, correct?

alex-s-gardner commented 1 year ago

@jhkennedy that is correct

alex-s-gardner commented 1 year ago

@mliukis when you have a chance can you confirm error calculation in mosaic code

alex-s-gardner commented 1 year ago

no action needed