nasa-jpl / autoRIFT

A Python module of a fast and intelligent algorithm for finding the pixel displacement between two images
Apache License 2.0
212 stars 52 forks source link

L7 bugfixes #79

Closed jhkennedy closed 10 months ago

jhkennedy commented 1 year ago
jhkennedy commented 1 year ago

@alex-s-gardner I did confirm we'll want these changes in production. Ideally, we'd cut a v1.5.1 release with these changes, and then hyp3-autorift can use the "canonical" version from conda-forge. I can move faster than that, however, with just these changes.

itstalmeez commented 10 months ago

I suggest reviewing the code related to this operator and implementing a more robust check to prevent negative variances. Additionally, ensure that the valid data is handled correctly, avoiding zero valid pixels. This fix will enhance the stability and reliability of the wallis_fill filter.

Feel free to share any specific code snippets or files related to this issue, and we can work together to make the necessary adjustments. Collaboration is key in open source, and your contribution in identifying this problem is greatly appreciated. Let's work together to resolve it and improve the project's overall quality.

jhkennedy commented 10 months ago

I suggest reviewing the code related to this operator and implementing a more robust check to prevent negative variances. Additionally, ensure that the valid data is handled correctly, avoiding zero valid pixels.

@itstalmeez I'm happy to review a pull request if you do any of the above or have further suggestions.