nasa-jpl / explorer-1

JPL's Design System
https://nasa-jpl.github.io/explorer-1/
MIT License
50 stars 9 forks source link

revising data model for EDU Lesson procedures #579

Closed stephiescastle closed 2 weeks ago

stephiescastle commented 2 weeks ago

Checklist

Description

Supports https://github.com/nasa-jpl/www/issues/413

Caveats

Instructions to test

  1. make vue-storybook
  2. View the PageEduLessonDetail story

Tested in the following environments/browsers:

Operating System

Browser

Scotchester commented 2 weeks ago

When using steps numbering, the first item in the "step" should be a rich text block (or similarly narrow block), otherwise the number will be covered up by wider media blocks.

@kimorr @otalutz Do you think this will be an acceptable limitation? Will most steps start with text?

Headings at levels larger than 4 look pretty funky due to the baselines of the number and the heading being far apart, but most likely and heading within one of these steps should be an H4, since "Procedures" is an H2 and procedure section headings would be H3.

stephiescastle commented 2 weeks ago

This is working pretty well for me! Just a couple needed changes in the stories, I think.

Made the changes! Forgot to do a lot of cleanup before opening the PR 🤦 thanks for the review!