nasa-jpl / explorer-1

JPL's Design System
https://nasa-jpl.github.io/explorer-1/
MIT License
56 stars 10 forks source link

adding trailing slashes in BaseLink #661

Closed stephiescastle closed 1 month ago

stephiescastle commented 1 month ago

Checklist

Description

Supports:

Adds a trailing slash to all links regardless if it's a router link or not. Checks urls for files and query params.

Instructions to test

Not testable in Storybook as we use a mock component for NuxtLink. Best way to test is in www. To do this locally:

  1. in www, replaced the @explorer-1 packages in /apps/frontend/package.json with the paths in /README.md
  2. pnpm i
  3. make frontend-local

Tested in the following environments/browsers:

Operating System

Browser