search

nasa-jpl / jsd

Just SOEM Drivers
Other
18 stars 17 forks source link

created github actions(#11) for building source code and testing it #75

Closed japrozs closed 1 year ago

japrozs commented 1 year ago

added github actions for CI – https://github.com/nasa-jpl/jsd/issues/11

alex-brinkman commented 1 year ago

@preston-rogers Is this ready for merge? It would be awesome to get the action setup and working

preston-rogers commented 1 year ago

Hey @japrozs, please let me know if you need further information. I will add the necessary changes to pass CI by EOD Thursday PST otherwise.

japrozs commented 1 year ago

Hey @japrozs, please let me know if you need further information. I will add the necessary changes to pass CI by EOD Thursday PST otherwise.

i think the PR is good to merge 👍🏼

preston-rogers commented 1 year ago

Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. https://github.com/japrozs/jsd/pull/1

japrozs commented 1 year ago

Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. japrozs#1

yep, i merged the PR. thanks for fixing the issues 👍🏼

preston-rogers commented 1 year ago

Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. japrozs#1

yep, i merged the PR. thanks for fixing the issues 👍🏼

No problem! My fault, but could you make a new PR trying to merge the master branch of your forked repo into the master branch of nasa-jpl? Accidentally made the necessary changes on your master branch. After the new PR is created please delete this one.

japrozs commented 1 year ago

yeah; i’ll create a new PR with the changes

japrozs commented 1 year ago

Hello @japrozs. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. japrozs#1

yep, i merged the PR. thanks for fixing the issues 👍🏼

No problem! My fault, but could you make a new PR trying to merge the master branch of your forked repo into the master branch of nasa-jpl? Accidentally made the necessary changes on your master branch. After the new PR is created please delete this one.

@preston-rogers here you go – https://github.com/nasa-jpl/jsd/pull/91

preston-rogers commented 1 year ago

Thank you Japroz 🙂

From: Japroz Saini @.> Sent: Wednesday, June 21, 2023 12:18 PM To: nasa-jpl/jsd @.> Cc: Rogers, Preston (US 347G) @.>; Mention @.> Subject: [EXTERNAL] Re: [nasa-jpl/jsd] created github actions(#11) for building source code and testing it (PR #75)

Hello @japrozshttps://urldefense.us/v3/__https://github.com/japrozs__;!!PvBDto6Hs4WbVuu7!J3tvyhNJlUOQkyXnpzwstsdBD0nYKM7azq_X-vnF6SQGFcwPWVcYYxPd_Fq_30PeKeaUZHl6b3chv3hl6y2ySzqKZTIt$. After testing your changes, the actions fail partly due to a variable unused warnings and because the chosen valgrind was failing on the ubuntu 22.04 runner. I made the necessary modifications in the following PR. Please merge this in and once that is done, I'm happy to merge this into the main JSD repo. japrozs#1https://urldefense.us/v3/__https://github.com/japrozs/jsd/pull/1__;!!PvBDto6Hs4WbVuu7!J3tvyhNJlUOQkyXnpzwstsdBD0nYKM7azq_X-vnF6SQGFcwPWVcYYxPd_Fq_30PeKeaUZHl6b3chv3hl6y2ySyYzqjRv$

yep, i merged the PR. thanks for fixing the issues 👍🏼

No problem! My fault, but could you make a new PR trying to merge the master branch of your forked repo into the master branch of nasa-jpl? Accidentally made the necessary changes on your master branch. After the new PR is created please delete this one.

@preston-rogershttps://urldefense.us/v3/__https://github.com/preston-rogers__;!!PvBDto6Hs4WbVuu7!J3tvyhNJlUOQkyXnpzwstsdBD0nYKM7azq_X-vnF6SQGFcwPWVcYYxPd_Fq_30PeKeaUZHl6b3chv3hl6y2yS81ghlFH$ here you go – #91https://urldefense.us/v3/__https://github.com/nasa-jpl/jsd/pull/91__;!!PvBDto6Hs4WbVuu7!J3tvyhNJlUOQkyXnpzwstsdBD0nYKM7azq_X-vnF6SQGFcwPWVcYYxPd_Fq_30PeKeaUZHl6b3chv3hl6y2yS0sRvPnv$

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https://github.com/nasa-jpl/jsd/pull/75*issuecomment-1601523182__;Iw!!PvBDto6Hs4WbVuu7!J3tvyhNJlUOQkyXnpzwstsdBD0nYKM7azq_X-vnF6SQGFcwPWVcYYxPd_Fq_30PeKeaUZHl6b3chv3hl6y2yS3O2kAAB$, or unsubscribehttps://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/A6R7S3X55N6NJAA35VVFKX3XMNCHVANCNFSM6AAAAAAXUB5BYY__;!!PvBDto6Hs4WbVuu7!J3tvyhNJlUOQkyXnpzwstsdBD0nYKM7azq_X-vnF6SQGFcwPWVcYYxPd_Fq_30PeKeaUZHl6b3chv3hl6y2yS4lgHWks$. You are receiving this because you were mentioned.Message ID: @.***>