search

nasa-jpl / open-source-rover

A build-it-yourself, 6-wheel rover based on the rovers on Mars!
https://open-source-rover.readthedocs.io
Apache License 2.0
8.63k stars 1.37k forks source link

Adding files for control board v2.0.1+2+3 #396

Closed apollokit closed 1 year ago

apollokit commented 1 year ago

Also, updates to arduino shield, and updates to pcb assembly READMEs

apollokit commented 1 year ago

This replaces the older draft PR here: https://github.com/nasa-jpl/open-source-rover/pull/198

Achllle commented 1 year ago

Might want to do a rebase, this seems to be re-introducing a bunch of files that were already deleted in the target branch

apollokit commented 1 year ago

Might want to do a rebase, this seems to be re-introducing a bunch of files that were already deleted in the target branch

Sure about that? Here's the diff: image

Are you saying that the hierarchy of electrical/pcb/control_board and electrical/pcb/arduino_uno_shield is not what we want?

Achllle commented 1 year ago

Is it doable to correct that atrocious sheild typo? :smiling_face_with_tear:

apollokit commented 1 year ago

Is it doable to correct that atrocious sheild typo? 🥲

oh boy, i hadn't even noticed that. Has that just always been there? I suppose it's fixable...

EDIT: fixed it now

Achllle commented 1 year ago

@apollokit can you remove the old files? I think it's best if they're not part of v2.

apollokit commented 1 year ago

@apollokit can you remove the old files? I think it's best if they're not part of v2.

done

apollokit commented 1 year ago

Merging this now to be done with it