nasa-jpl / osr-rover-code

Code that runs on the Open Source Rover
Apache License 2.0
435 stars 148 forks source link

[bug report] screen.py status check functions: scaling incorrect #160

Closed SallyTYT closed 1 year ago

SallyTYT commented 2 years ago

https://github.com/nasa-jpl/osr-rover-code/blob/master/ROS/led_screen/src/screen.py

The status data should not be scaled by a factor of 0.1

line 70 >> battery = 0.1 line 96 >> val = temperature[i][j] 0.1 line 119 >> val = currents[i][j] 0.1 line 140 >> val = currents[i][j] 0.1

ericjunkins commented 2 years ago

Can you give more context on why you think this is incorrect? I believe it is correct as is currently

SallyTYT commented 2 years ago

@ericjunkins

If scaling by 0.1, the out_msg[3], [5]~[12] would always be zero, image And the LED screen would always be like this, d92461e39f12c3b28d64d9b661b8cbb

If removing the scaling, the out_msg would have valid values, It works just like this document describes https://github.com/nasa-jpl/osr-rover-code/blob/master/OsrScreen/README.md image And the LED screen would work well too, f64c068e0fa90d13c1da91fa10e54ef