nasa-jpl / osr-rover-code

Code that runs on the Open Source Rover
Apache License 2.0
435 stars 148 forks source link

Add support for duty control of drive motors #171

Closed Achllle closed 8 months ago

Achllle commented 1 year ago

This is easy to add in code but we'll need to modify the command message or create a new one.

Right now the rover only supports velocity control. In some cases it could be better to command duty cycle to the drive motors as opposed to doing closed loop velocity control. This would likely mean less stress on the rover while driving, even though the motions are not as 'accurate' in some sense.

Achllle commented 1 year ago

I changed my mind on this - using duty cycle just lowers speed, so you end up with less accurate speed control. The actual fix would be to change the ramping behavior of the speed control by changing acceleration settings.

ericjunkins commented 1 year ago

I would make the case that during manual drive with a controller you might prefer open loop instead of closed loop speed control, and that closed loop is really only beneficial for autonomous functionality

Achllle commented 1 year ago

True, true - I'll undo that change.

Achllle commented 8 months ago

completed with #178