nasa-jpl / osr-rover-code

Code that runs on the Open Source Rover
Apache License 2.0
435 stars 148 forks source link

Don't include roboclaw.py ourselves #46

Open Achllle opened 4 years ago

Achllle commented 4 years ago

Instead of duplicating the source for the roboclaw code (roboclaw.py), we should clone the official repo, perhaps fork it to turn it into a catkin or pip package.

This ensure we can get updates properly, keep our codebase smaller and cleaner, and report issues related to roboclaw code in their repo where we will find official support.

Achllle commented 4 years ago

Or, since the official repo isn't the greatest of quality and has zero documentation or support, it might make sense to turn to user repos:

Achllle commented 4 years ago

I'm working on this at https://github.com/Achllle/libroboclaw and https://github.com/Achllle/roboclaw-hardware-interface

ericjunkins commented 4 years ago

roger 👍