merge rover.py and robot.py and roboclaw_wrapper.py and motor_controller.py

nasa-jpl / osr-rover-code

Code that runs on the Open Source Rover

Apache License 2.0

435 stars 148 forks source link

Closed Achllle closed 4 years ago

Achllle commented 4 years ago

The rover.py node doesn't really do much other than relay updates from the joy node and encoder updates to commands to the robot. Propose to merge rover.py and robot.py and move joy code to joystick.py
Similar for roboclaw_wrapper.py and motor_controller.py. Naming is also confusing (class MotorController lives in roboclaw_wrapper.py) and should just be one file.

Achllle commented 4 years ago

The way to deal with multiple joystick mappings (relevant: #13) is to have separate classes for different joystick types.