search

nasa / CCDD

CFS Command and Data Dictionary Tool (CCDDT)
81 stars 31 forks source link

Problems with the copyTable.js script #111

Closed mVanSteen closed 1 year ago

mVanSteen commented 1 year ago

I think there are some errors/typos in the copyTable.js script (and the ones in other languages). Correcting the following lines in the file seems to fix the problem for me.

change line 111: if (tlmMsgIDs[index][0] == usedHKNames[index]) to : if (tlmMsgIDs[msgIndex][0] == usedHKNames[index])

change line 130: _var copyTableEntries = ccdd.getCopyTableEntries(copyTables[copyTable], CCSDS_HEADERLENGTH, "Message ID Name", true); to: _var copyTableEntries = ccdd.getCopyTableEntries(copyTables[copyTable], CCSDS_HEADERLENGTH, "Telemetry message name & ID", true);

I could just have forgotten something but those lines seem strange to me and produced the expected output after some testing. Thank you for the help

KevinMcCluney commented 1 year ago

Thanks for information! The scripts have been altered and uploaded. Since the message ID name is user-defined, the script would need to be updated to match the project. As the default it makes sense to use the message ID name in the tutorial.