search

nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
79 stars 45 forks source link

CFDP protocol timer configuration is not per channel (CF5002 and CF4000.1.1 failure) #120

Closed semaldona closed 2 years ago

semaldona commented 2 years ago

Per requirement CF5002, protocol timer configuration should be per channel. Currently the values are applied to all channels.

skliper commented 2 years ago

None of these are by channel, although the requirements also have issues since 1 and 4 are duplicates. Either way, these likely should really be per channel since some could be local and others quite far away so changing this to a bug.

CF5002,CF5002,"The following parameters shall be configurable by a CF command:

  1. CFDP channel Ack-Timer Value (seconds)
  2. CFDP channel NAK-Timer Value (seconds)
  3. CFDP channel Inactivity-Timeout Value (seconds)
  4. CFDP channel Ack-Timer Value (seconds)
  5. CFDP channel Maximum Ack Timeouts (integer counts)
  6. CFDP channel Maximum NAK Timeouts (integer counts)","Operational interface to support mission variability and reconfiguration"

CF5002.1,CF5002.1,"The default values for the CFDP channel protocol parameters below shall be defined by a CF Configuration Table:

  1. CFDP channel Ack-Timer Value (seconds)
  2. CFDP channel NAK-Timer Value (seconds)
  3. CFDP channel Inactivity-Timeout Value (seconds)
  4. CFDP channel Ack-Timer Value (seconds)
  5. CFDP channel Maximum Ack Timeouts (integer counts)
  6. CFDP channel Maximum NAK Timeouts (integer counts)",Ensure CF starts in a known and valid operational state
skliper commented 2 years ago

Note with update in #248, this also fails CF4000.1.1

skliper commented 2 years ago

Note duplicated element in requirement is addressed in #248, so just the bug remains to resolve.