skliper
commented
2 years ago Issue details: "Channel parameters" is really for each channel, there isn't really any such thing as a "playback channel" anymore. Recommend fixing requirement.
Pending Queue Depth: Requirements issue - Concept has changed... it's a transaction and the transactions can be in a pending state. Total transactions supported is configured via compile defines in the platform configuration. History Queue Depth - same issue as pending Channel Name - No longer exist. Channels are reference by index. Recommend just deleting from requirement.
Polling dir - no option to keep files... doesn't really make sense for polling since it would just keep sending them. Note playback just cycles through once, so the keep option is supported in playback dir commands. Recommend delete from requirement.
"Input channel parameters" - need to consolidate under channel parameters... these are no longer separate. Response is on the same channel. Recommend fixing requirement.
Current requirement: CF4000.1.1,CF4000.1.1,"The ""CF Channel Configuration Table"" shall define the following parameters: -- Channel parameters (repeated for each playback channel)
- Dequeue Enable
- Downlink PDU MID
- Pending Queue Depth
- History Queue Depth
- Channel Name
- Handshake Semaphore Name -- Polling Directory Parameters (repeated for each polling directory)
- Enable State
- CFDP Class
- Priority
- Source Path
- Destination Path
- Preserve file
- Peer Entity Id -- Input channel parameters (repeated for each input channel)
- Input PDU MID
- Class 2 Uplink Response Channel
Per requirement CF4000.1.1, all specified values should be present in the configuration table. Currently, only some of the values are present. Values not specified in the requirement are also present in the table. For example, the history queue depth and channel name are specified but are not implemented.