rename the functions to better indicate what they do
do not discard the part of the output that has EID/TSN/CC information
do not pass the return value of snprintf directly to write(), use strlen()
simplify the code
Fixes #40
Testing performed
Build and unit test CF.
Run two instances of CFE+CF, execute transfer in both directions and confirm
Issue CF_WRITE_QUEUE_CC (15) to write the transaction and history queues to the file
Confirm contents of the file are correct.
Expected behavior changes
The file contains the information it is intended to contain, mainly the SEQ/DIR/PEER/CC bits are not omitted. There is also no risk of buffer overruns.
Here is an example file output, after running two transactions between two nodes (one RX, one TX)
astrogeco
commented
2 years ago
Describe the contribution
Fixes #40
Testing performed Build and unit test CF. Run two instances of CFE+CF, execute transfer in both directions and confirm Issue CF_WRITE_QUEUE_CC (15) to write the transaction and history queues to the file Confirm contents of the file are correct.
Expected behavior changes The file contains the information it is intended to contain, mainly the SEQ/DIR/PEER/CC bits are not omitted. There is also no risk of buffer overruns.
Here is an example file output, after running two transactions between two nodes (one RX, one TX)
System(s) tested on Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.