search

nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
86 stars 46 forks source link

Fix #94, move all bitfields into codec #182

Closed jphickey closed 2 years ago

jphickey commented 2 years ago

Describe the contribution Nothing outside of the codec code should need to know about the bitfields in the CFDP protocol definition. Everything else uses logical values.

This moves all DECLARE_FIELD macros into cf_codec.c and removes cf_field.h.

Fixes #94 Fixes #65

Testing performed Build and sanity check CF Run all unit tests Run some file transfers

Expected behavior changes None, code clean up

System(s) tested on Ubuntu 21.10

Additional context This just puts these definitions on the "need to know" basis, by not exposing them outside the only file where they matter.

Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.

astrogeco commented 2 years ago

CCB:2022-01-19 APPROVED