nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
78 stars 45 forks source link

Replace codec code-compatibility macros with direct calls to the new functions #227

Closed skliper closed 2 years ago

skliper commented 2 years ago

Checklist (Please check before submitting)

Is your feature request related to a problem? Please describe. These were used to help transition the code from old endian dependent macros, but they obscure the fact values are being modified by taking address of the input. They also cause static analysis warnings on occasion as identified in #216.

Example: https://github.com/nasa/CF/blob/d0b3e25566b7cb8221d8a3f90017fe52ee0f43d4/fsw/src/cf_codec.c#L134-L138

Describe the solution you'd like Convert the code to use the functions directly, remove offending macros.

Describe alternatives you've considered None

Additional context

Requester Info Jacob Hageman - NASA/GSFC

skliper commented 2 years ago

@astrogeco this got reopened... was this intended? If not need to resolve what is causing this.

astrogeco commented 2 years ago

sigh, nope I wonder if by typing the PR number in a new commit causes the reopening