Closed skliper closed 2 years ago
CCB:2022-04-13 APPROVED
Resolved conflict and added hotfixes to fix cppcheck error quoted below. See fix in https://github.com/astrogeco/CF/commit/96cdf3071996eb98fd1920e7ea39d7af0a2f85c8
[fsw/src/cf_codec.h:821] -> [fsw/src/cf_codec.c:1050]: (style, inconclusive) Function 'CF_CFDP_DecodeCrc' argument 2 names different: declaration 'pcrc' definition 'plcrc'.
Error: Process completed with exit code 255.
Checklist (Please check before submitting)
Describe the contribution
Testing performed Build/run unit tests, also manually ran strict cppcheck on fsw/
Expected behavior changes None except now enforcing strict cppcheck in CI
System(s) tested on
Additional context Workflow will fail until #226 is merged since one of the warnings were fixed there. Also will fail until nasa/cFS#454 is merged based on the directory fix
Third party code None
Contributor Info - All information REQUIRED for consideration of pull request Jacob Hageman - NASA/GSFC