nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
86 stars 46 forks source link

Fix #214, Resolve buffer overflow in CF_Chunks_InsertChunk unit test #240

Closed skliper closed 2 years ago

skliper commented 2 years ago

Checklist (Please check before submitting)

Describe the contribution

Rewrites problematic CF_Chunk_InsertChunk tests that occasionally had a buffer overflow due to random number use.

Testing performed Build and ran unit tests, confirmed passing. Also confirmed no loss in coverage.

Expected behavior changes Just fixes random unit test failures on a 32 bit system.

System(s) tested on

Additional context None

Third party code None

Contributor Info - All information REQUIRED for consideration of pull request Jacob Hageman - NASA/GSFC

skliper commented 2 years ago

@chillfig - what's the status on this PR? If not CCB:Ready is it CCB:Approved?

chillfig commented 2 years ago

@chillfig - what's the status on this PR? If not CCB:Ready is it CCB:Approved?

The status is still CCB:Ready. I removed the label when I added this PR to the CCB agenda: https://github.com/nasa/cFS/wiki/CCB:-2022.05.18 In the future I will remove the CCB:Ready label after the cFS Community CCB meeting instead of before.

astrogeco commented 2 years ago

CCB:2022-05-18 APPROVED