[x] I reviewed the CF README.md file to see if the feature is in the major future work.
[x] I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
There's a significant amount of unit test logic dedicated to confirming argument inputs to stub functions that go above and beyond the requirements of a coverage test. This logic is associated with defining and saving *_context_t structures from within stubs. While there is technically nothing wrong with these tests (they all pass), the issue is with technical debt. Unless the test is verifying requirements/spec/algorithm document there's also the question of what is truth.
Describe the solution you'd like
Use functional tests to verify function. Remove context checks that don't add value in the coverage test context.
Describe alternatives you've considered
Leave as is, but whenever maintenance is performed encourage simplification. At minimum we should avoid this pattern in new or updated tests.
Additional context
Along the same lines as removing the randomness, these aren't intended to be fuzz tests.
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe. There's a significant amount of unit test logic dedicated to confirming argument inputs to stub functions that go above and beyond the requirements of a coverage test. This logic is associated with defining and saving *_context_t structures from within stubs. While there is technically nothing wrong with these tests (they all pass), the issue is with technical debt. Unless the test is verifying requirements/spec/algorithm document there's also the question of what is truth.
Describe the solution you'd like Use functional tests to verify function. Remove context checks that don't add value in the coverage test context.
Describe alternatives you've considered Leave as is, but whenever maintenance is performed encourage simplification. At minimum we should avoid this pattern in new or updated tests.
Additional context Along the same lines as removing the randomness, these aren't intended to be fuzz tests.
86
Requester Info Jacob Hageman - NASA/GSFC