nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
78 stars 45 forks source link

Abandon and Cancel commands with invalid transaction IDs are silently dropped (not rejected) #273

Closed semaldona closed 2 years ago

semaldona commented 2 years ago

Checklist (Please check before submitting)

Describe the bug CF requirements CF5006.1 and CF5007.1 state that, if the command-specified transaction is not in progress, CF shall reject the command. Requirements CF5015.1 and CF5017.1 cover "all" transactions and state that, if there are no transactions in progress, CF shall reject the command. CF does not reject such a command by either issuing an event message or incrementing the command failure counter. CF does not take any action other than incrementing the command counter.

To Reproduce Steps to reproduce the behavior: Issue the Abandon or Cancel command with a transaction ID that is invalid and/or not currently in progress. Issue the Abandon or Cancel command with the "all" specifier when no transactions are currently in progress.

Expected behavior To be consistent with other transaction based commands, CF should provide operator feedback if it fails to find the active transaction ID. At the minimum, it should issue an event message and increment the command failure counter.

System observed on: Ubuntu 20.04 Linux 5.13

Reporter Info Sergio Maldonado, NASA GSFC, Arctic Slope Technical Services

skliper commented 2 years ago

Resolved by #282.