Fix #213, updated CFDP class validation

havencarlson commented 2 years ago

Checklist (Please check before submitting)

[X] I reviewed the Contributing Guide.
[X] I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution Fix #213, add validation to CF_CmdTxFile() and CF_CmdPlaybackDir() to prevent negative CFDP class values.

Testing performed Unit testing

Expected behavior changes Reject command if CFDP class is negative

System(s) tested on

OS: Ubuntu 18.04

Contributor Info - All information REQUIRED for consideration of pull request Haven Carlson - NASA

dzbaker commented 2 years ago

CCB 3 Aug 2022: Check that it is equal to 1 or 2 in validation.

jphickey commented 2 years ago

Here's another suggestion - define CF_CLASS_MAX in the enum, and check that it is not greater than that. That's the way I often see enums validated, as it avoids the assumption that a certain label is the "last one"

nasa / CF

Fix #213, updated CFDP class validation #303