Double semicolon in #define macro?

[thnkslprpt]

Checklist

• [x] I reviewed the Contributing Guide.
• [x] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Code snips Does this macro expand out and result in a double-semicolon (i.e. an empty statement)? https://github.com/nasa/CF/blob/e1daebed33b02929945caa44404e491ef7a56d02/unit-test/utilities/cf_test_utils.h#L222

For example, here: https://github.com/nasa/CF/blob/e1daebed33b02929945caa44404e491ef7a56d02/unit-test/cf_chunk_tests.c#L355-L358

Reporter Info Avi Weiss @thnkslprpt

[chillfig]

Nice catch. In C, an extra semicolon like this is not a syntax error. It's essentially a null statement, so the compiler will likely optimize it away, and it should not affect the behavior of the program. Still, it's generally not a desired style, and we may want to avoid defining it this way to make the code cleaner... Adding fix