Extraneous assignments to CFE_SUCCESS - Githubissues

nasa / CF

The Core Flight System (cFS) CFDP application.

Apache License 2.0

76 stars 45 forks source link

Extraneous assignments to CFE_SUCCESS #365

Closed thnkslprpt closed 1 year ago

thnkslprpt commented 1 year ago

Checklist

[x] I reviewed the Contributing Guide.
[x] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug CF has a few extraneous assignments to CFE_SUCCESS as in https://github.com/nasa/HS/issues/10

Code snips https://github.com/nasa/CF/blob/19c18b9dbdb0093e9bea78322de777e8f282acfb/fsw/src/cf_app.c#L151-L156 https://github.com/nasa/CF/blob/19c18b9dbdb0093e9bea78322de777e8f282acfb/fsw/src/cf_cfdp.c#L1324-L1331

Expected behavior Remove assignments - unnecessary code.

Reporter Info Avi Weiss @thnkslprpt