nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
76 stars 45 forks source link

Fix #105, Remove 'dummy' from variable names #367

Closed thnkslprpt closed 1 year ago

thnkslprpt commented 1 year ago

Checklist

Describe the contribution Fixes #105 Removed (unnecessary) use of 'dummy' in several variable names. Note there are several other issues open to clean up the unit tests in CF, including improving/shortening the test function names.

Testing performed GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes None

Contributor Info Avi Weiss @thnkslprpt

dzbaker commented 1 year ago

Hey @thnkslprpt, would you be able to resolve the conflicts? Thanks!

thnkslprpt commented 1 year ago

Tied myself in a few knots and somehow closed this PR. I know it's possible to re-open this PR, but thought it might be simpler to re-submit as a single commit without the merge conflicts etc. https://github.com/nasa/CF/pull/370 Apologies for the re-assessment...