[x] I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.
Describe the contribution
Fixes #382
Command counters renamed
cmd renamed to CommandCounter
err renamed to CommandErrorCounter
Command counters changed from size 16 to size 8, and moved out of their own struct into the HK packet directly (this is how all other cFS components/apps implemented the counters)
hk renamed to HkPacket (most cFS components/apps use this common name for the housekeeping packet)
Note: if the CamelCase is an issue, can still implement these changes as snake_case, although I guess now is as good a time as any to start converting CF variables to CamelCase. If so I can open a new issue to flag that all variables should be changed over - all at once (if someone wants to implement that) or gradually as changes are made.
CF is the only cFS app/component to use snake_case for naming variables.
Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit Tests etc.).
Expected behavior changesCommand/CommandError counters now held directly in the HK packet, instead of through an additional struct member.
This PR improves consistency across cFS, and makes future maintenance easier as variables are named and located as expected.
Checklist
Describe the contribution
cmdrenamed toCommandCountererrrenamed toCommandErrorCounterhkrenamed toHkPacket(most cFS components/apps use this common name for the housekeeping packet)Note: if the
CamelCaseis an issue, can still implement these changes assnake_case, although I guess now is as good a time as any to start converting CF variables toCamelCase. If so I can open a new issue to flag that all variables should be changed over - all at once (if someone wants to implement that) or gradually as changes are made. CF is the only cFS app/component to usesnake_casefor naming variables.Testing performed GitHub CI actions all passing successfully (incl. Build + Run, Unit Tests etc.).
Expected behavior changes
Command/CommandErrorcounters now held directly in the HK packet, instead of through an additional struct member.This PR improves consistency across cFS, and makes future maintenance easier as variables are named and located as expected.
Contributor Info Avi Weiss @thnkslprpt