Open dzbaker opened 1 year ago
@thnkslprpt I reverted the original (#383) so we could move it to the next release. Does everything look good here?
@thnkslprpt I reverted the original (#383) so we could move it to the next release. Does everything look good here?
Yep - looks good mate. Cheers
Checklist
Describe the contribution
cmd
renamed toCommandCounter
err
renamed toCommandErrorCounter
hk
renamed toHkPacket
(most cFS components/apps use this common name for the housekeeping packet)Note: if the
CamelCase
is an issue, can still implement these changes assnake_case
, although I guess now is as good a time as any to start converting CF variables toCamelCase
. If so I can open a new issue to flag that all variables should be changed over - all at once (if someone wants to implement that) or gradually as changes are made. CF is the only cFS app/component to usesnake_case
for naming variables.Re-introduced from #383.#394, #397 reverted this PR.
Testing performed GitHub CI actions all passing successfully (incl. Build + Run, Unit Tests etc.).
Expected behavior changes
Command
/CommandError
counters now held directly in the HK packet, instead of through an additional struct member.This PR improves consistency across cFS, and makes future maintenance easier as variables are named and located as expected.
Contributor Info Avi Weiss @thnkslprpt