nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
76 stars 45 forks source link

Fix #288, Remove unnecessary `CF_UnionArgs_Payload_t` union #400

Open thnkslprpt opened 1 year ago

thnkslprpt commented 1 year ago

Checklist

Describe the contribution

Testing performed GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes No impact on logic. Code is simplified and clearer.

Contributor Info Avi Weiss @thnkslprpt

thnkslprpt commented 9 months ago

We need to also do this but I'd like to approach it a bit differently. Although only the "byte" field is used now, it is still used for a few different things in different commands. Now that each command has its own definition, this should be made type-correct.

@jphickey So you want to create command-specific struct members for each command? What exactly do you mean in terms of the solution to make it type-correct? Cheers