Closed skliper closed 10 months ago
Checklist (Please check before submitting)
Describe the bug Passing 192 (for default OS_MAX_PATH_LEN of 64) instead of 180 due to use of SB buffer size instead of packet size. https://github.com/nasa/CF/blob/5df892e8161b423de0fe70a87b9481842558429d/fsw/src/cf_cfdp.c#L1706-L1715 https://github.com/nasa/CF/blob/5df892e8161b423de0fe70a87b9481842558429d/fsw/inc/cf_msg.h#L156-L160
To Reproduce Can confirm from a cmd/tlm server or inline: sizeof(CF_EotPktBuf_t) is 192 sizeof(CF_EotPacket_t) is 180
Expected behavior Pass in the actual packet size, not the SB buffer size which has the most strict alignment/rounding requirements.
Code snips See above
System observed on:
Additional context None
Reporter Info Jacob Hageman - NASA/GSFC
Checklist (Please check before submitting)
Describe the bug Passing 192 (for default OS_MAX_PATH_LEN of 64) instead of 180 due to use of SB buffer size instead of packet size. https://github.com/nasa/CF/blob/5df892e8161b423de0fe70a87b9481842558429d/fsw/src/cf_cfdp.c#L1706-L1715 https://github.com/nasa/CF/blob/5df892e8161b423de0fe70a87b9481842558429d/fsw/inc/cf_msg.h#L156-L160
To Reproduce Can confirm from a cmd/tlm server or inline: sizeof(CF_EotPktBuf_t) is 192 sizeof(CF_EotPacket_t) is 180
Expected behavior Pass in the actual packet size, not the SB buffer size which has the most strict alignment/rounding requirements.
Code snips See above
System observed on:
Additional context None
Reporter Info Jacob Hageman - NASA/GSFC