nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
80 stars 45 forks source link

Fix #392, seg fault - invalid file destination #412

Closed dmknutsen closed 11 months ago

dmknutsen commented 11 months ago

Checklist (Please check before submitting)

Describe the contribution Fixes #392 - Adds logic to CF_CFDP_ResetTransaction to check if a transaction has previously been freed prior to resetting the transaction. This PR includes an additional requirement - which is now verified via an updated build verification test to ensure this condition is induced/verified as part of our build release. I also included an additional unit test to maintain 100% coverage.

Testing performed Steps taken to test the contribution:

  1. Unit/coverage testing
  2. Build verification testing - which includes sending a PDUs with invalid destination filename(s) to ensure doing so is now being handled correctly.

System(s) tested on

Contributor Info - All information REQUIRED for consideration of pull request Full name and company/organization/center of all contributors ("Personal" if individual work) Dan Knutsen NASA Goddard