nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
76 stars 45 forks source link

Fix #418, reorganize header files and restructure messages #419

Closed jphickey closed 7 months ago

jphickey commented 7 months ago

Checklist (Please check before submitting)

Describe the contribution Move the header files to a "config" directory as documented in the CFE guidelines, which allows easier override.

Organize the content to adhere to the patterns.

Specifically - adds a dedicated structure type for each cmd, and also puts the payload into a separate sub-structure.

Command handlers and tests updated accordingly (many of which were simplified).

Fixes #418

Testing performed Build and run all tests Execute local file transfer using 2 instances of CFS + CFDP app

Expected behavior changes Nothing on the external interface changes

System(s) tested on Debian

Additional context First step of making CF adhere to current patterns

Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.

dzbaker commented 7 months ago

CCB 30 November 2023: Approved pending rebase.

jphickey commented 7 months ago

@dzbaker -- this is now rebased, should be OK