search

nasa / CF

The Core Flight System (cFS) CFDP application.
Apache License 2.0
80 stars 45 forks source link

Static analysis issues JSC 2.1 #444

Closed chillfig closed 3 months ago

chillfig commented 4 months ago

Checklist (Please check before submitting)

Describe the bug Handful of static analysis issues. This report records the findings from the static analysis to facilitate their tracking.

<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">

Source Folder Source Filename Source Line Source Object Disposition
Unsafe Functions: (Medium Risk)        
\apps\cf\fsw\src cf_utils.c 199 strlen Will Fix. CF PR #448
Unchecked Return Value on Function / Truncation of Data Risk        
\apps\cf\fsw\src cf_utils.c 186 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.
\apps\cf\fsw\src cf_utils.c 191 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.
\apps\cf\fsw\src cf_utils.c 195 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.

To Reproduce N/A. These issues were communicated by JSC.

Expected behavior A clear and concise description of what you expected to happen.

Code snips N/A

System observed on: N/A

Additional context N/A

Reporter Info Imported from JSC 2.1 static analysis Source Folder Source Filename Source Line Source Object Disposition Unsafe Functions: (Medium Risk)
\apps\cf\fsw\src cf_utils.c 199 strlen Will Fix. CF PR #448

Unchecked Return Value on Function / Truncation of Data Risk
\apps\cf\fsw\src cf_utils.c 186 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output. \apps\cf\fsw\src cf_utils.c 191 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output. \apps\cf\fsw\src cf_utils.c 195 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.