Closed thnkslprpt closed 1 year ago
Checklist
Describe the bug These function prototypes can/should be moved into the header file. It's a little incongruous with the rest of cFS. https://github.com/nasa/CS/blob/591d0823eaf1240eafaff67b8f7398a4efd1e956/fsw/src/cs_app.c#L54-L132 I assume the original intent was to keep them private if they were not needed as part of the interface.
Expected behavior Unless these are specifically being kept private, it seems better to keep CS consistent with the other apps and move these to the header file.
Reporter Info Avi Weiss @thnkslprpt
Checklist
Describe the bug These function prototypes can/should be moved into the header file. It's a little incongruous with the rest of cFS. https://github.com/nasa/CS/blob/591d0823eaf1240eafaff67b8f7398a4efd1e956/fsw/src/cs_app.c#L54-L132 I assume the original intent was to keep them private if they were not needed as part of the interface.
Expected behavior Unless these are specifically being kept private, it seems better to keep CS consistent with the other apps and move these to the header file.
Reporter Info Avi Weiss @thnkslprpt