nasa / Common-Metadata-Repository

Apache License 2.0
340 stars 94 forks source link

CMR-9740: Modify kms-* caches refresh logic #2074

Closed jmaeng72 closed 8 months ago

jmaeng72 commented 8 months ago

Overview

What is the feature/fix?

To prevent kms-* caches from refreshing if there is a redis connection error or redis related exception

What is the Solution?

Allow the exception to bubble up to kms calls and then throw the exception or return nil as result

What areas of the application does this impact?

Any cache using redis (since we are now throwing the exception found), search-app

Checklist

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 67.08861% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 58.09%. Comparing base (41c9940) to head (4ceca72).

Files Patch % Lines
...app-lib/src/cmr/common_app/services/kms_lookup.clj 75.40% 26 Missing and 4 partials :warning:
...pp-lib/src/cmr/common_app/services/kms_fetcher.clj 35.29% 19 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2074 +/- ## ========================================== + Coverage 58.07% 58.09% +0.01% ========================================== Files 1043 1043 Lines 69749 69788 +39 Branches 1953 1955 +2 ========================================== + Hits 40510 40546 +36 + Misses 27402 27401 -1 - Partials 1837 1841 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.