nasa / Common-Metadata-Repository

Apache License 2.0
340 stars 94 forks source link

CMR-9742: Modify coll caches refresh logic #2076

Closed jmaeng72 closed 8 months ago

jmaeng72 commented 8 months ago

Overview

What is the feature/fix?

Collection-* caches (some of them) attempt to refresh their cache when running into a redis connection error.

What is the Solution?

Have the collection-* caches not refresh caches if it runs into a redis connection error or other exception. This means that if a redis connection exception occurs, the client will get a 500 server error due to the exception.

I also renamed the collection-has-gran cache to be singular since there is only one cache now

What areas of the application does this impact?

Search app

Checklist

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.09%. Comparing base (41c9940) to head (dbb685f). Report is 1 commits behind head on master.

Files Patch % Lines
...r-app/src/cmr/indexer/data/concepts/collection.clj 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2076 +/- ## ========================================== + Coverage 58.07% 58.09% +0.01% ========================================== Files 1043 1042 -1 Lines 69749 69748 -1 Branches 1953 1951 -2 ========================================== + Hits 40510 40521 +11 + Misses 27402 27390 -12 Partials 1837 1837 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.