CMR-9783: Lint message-queue-lib

[jceaser]

Overview

updated the lint tools and made changes to work with these tools and also the clj-kondo tool

What is the feature

Use this ticket to investigate the level of effort needed to bring a project up to code against clj-kondo.

Please summarize the feature or fix. Mostly changes made to remove code or define code in such a way as to be clearly declared by the run time in advance. (declare) statements all over the place now.

What is the Solution?

adding declare statements, removing unused variables. I did tell eastwood to ignore reflection warnings as I don't understand those yet

What areas of the application does this impact?

This is almost exclusively in message-queue-lib, one file in common.

Checklist

• [n/a] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
• [x] New and existing unit and int tests pass locally and remotely with my changes
• [x] I have removed unnecessary/dead code and imports in files I have changed
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 47.72727% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 27.96%. Comparing base (0eb80fa) to head (b0d90e1). Report is 2 commits behind head on master.

Files	Patch %	Lines
...sage-queue-lib/src/cmr/message_queue/queue/sqs.clj	42.85%	12 Missing :warning:
...rc/cmr/message_queue/test/queue_broker_wrapper.clj	0.00%	7 Missing :warning:
...e-lib/src/cmr/message_queue/queue/memory_queue.clj	50.00%	2 Missing :warning:
...queue-lib/src/cmr/message_queue/services/queue.clj	50.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2084 +/- ## =========================================== - Coverage 55.42% 27.96% -27.46% =========================================== Files 1042 1042 Lines 69874 69873 -1 Branches 2053 1186 -867 =========================================== - Hits 38726 19539 -19187 - Misses 29212 49150 +19938 + Partials 1936 1184 -752 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.