nasa / Common-Metadata-Repository

Apache License 2.0
337 stars 92 forks source link

CMR-9773: Linter updates for access control #2089

Closed eereiter closed 5 months ago

eereiter commented 5 months ago

Overview

What is the feature/fix?

Changing the access control software to mitigate linter findings.

What is the Solution?

Removing not needed required statements and putting meaningless declarations in front of every macro so the linter doesn't complain about them.

What areas of the application does this impact?

access control and supporting libraries.

Checklist

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 72.64151% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 56.69%. Comparing base (e91674b) to head (f0b6117). Report is 2 commits behind head on master.

Files Patch % Lines
...src/cmr/access_control/services/acl_validation.clj 0.00% 5 Missing :warning:
...cess-control-app/src/cmr/access_control/runner.clj 0.00% 3 Missing :warning:
...pp/src/cmr/access_control/services/acl_service.clj 57.14% 3 Missing :warning:
.../src/cmr/access_control/services/event_handler.clj 0.00% 3 Missing :warning:
.../src/cmr/access_control/services/group_service.clj 0.00% 3 Missing :warning:
...r/access_control/services/parameter_validation.clj 0.00% 3 Missing :warning:
...-control-app/src/cmr/access_control/api/routes.clj 0.00% 2 Missing :warning:
...-app/src/cmr/access_control/data/elasticsearch.clj 33.33% 2 Missing :warning:
transmit-lib/src/cmr/transmit/metadata_db.clj 87.50% 2 Missing :warning:
...s_control/services/permitted_concept_id_search.clj 0.00% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2089 +/- ## ========================================== + Coverage 56.65% 56.69% +0.04% ========================================== Files 1042 1042 Lines 69947 70014 +67 Branches 2009 2004 -5 ========================================== + Hits 39625 39692 +67 + Misses 28436 28432 -4 - Partials 1886 1890 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.