CMR-9839: Granule metadata with granuleSize info yields unexpected results at ingest

nasa / Common-Metadata-Repository

Apache License 2.0

337 stars 92 forks source link

Overview

What is the feature/fix?

CMR granule json search. Customer wants granule_size returned to be calculated differently.

What is the Solution?

Add all the SizeInBytes (or Size if SizeInBytes is absent) in all the files when ingesting UMM-G granule and use it for granule_size.

What areas of the application does this impact?

CMR granule search

Checklist

[ x] I have updated/added unit and integration tests that prove my fix is effective or that my feature works

[x ] New and existing unit and int tests pass locally and remotely with my changes

[ x] I have removed unnecessary/dead code and imports in files I have changed

[x ] I have performed a self-review of my own code

[x ] I have commented my code, particularly in hard-to-understand areas

[ ] I have made corresponding changes to the documentation

[ x] My changes generate no new warnings

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 57.84%. Comparing base (d0423b1) to head (6fa4bbf). Report is 3 commits behind head on master.

Files	Patch %	Lines
...-lib/src/cmr/umm_spec/test/umm_g/expected_util.clj	68.75%	5 Missing :warning:
...m-spec-lib/src/cmr/umm_spec/umm_g/data_granule.clj	95.23%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2103 +/- ## ======================================= Coverage 57.83% 57.84% ======================================= Files 1041 1041 Lines 70289 70321 +32 Branches 1984 1982 -2 ======================================= + Hits 40653 40677 +24 - Misses 27770 27775 +5 - Partials 1866 1869 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nasa / Common-Metadata-Repository